Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add podman support #1501

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Add podman support #1501

wants to merge 1 commit into from

Conversation

d-513
Copy link

@d-513 d-513 commented Dec 16, 2022

Closes #1060

When making container, it checks if running in podman (by checking if /run/.containerenv file exists, that only is made when running with podman). If yes, then it applies workarounds:

  • Removes leading slash from container name (podman doesn't support that)
  • Doesnt set ulimits (also breaks podman)

@d-513 d-513 requested a review from simskij as a code owner December 16, 2022 12:15
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congratulations on opening your first pull request! We'll get back to you as soon as possible. In the meantime, please make sure you've updated the documentation to reflect your changes and have added test automation as needed. Thanks! 🙏🏼

@codecov
Copy link

codecov bot commented Dec 16, 2022

Codecov Report

Base: 66.19% // Head: 65.96% // Decreases project coverage by -0.22% ⚠️

Coverage data is based on head (ae0e308) compared to base (d2cfefb).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1501      +/-   ##
==========================================
- Coverage   66.19%   65.96%   -0.23%     
==========================================
  Files          24       24              
  Lines        2313     2321       +8     
==========================================
  Hits         1531     1531              
- Misses        682      690       +8     
  Partials      100      100              
Impacted Files Coverage Δ
pkg/container/client.go 40.34% <0.00%> (-0.96%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@d-513
Copy link
Author

d-513 commented Dec 18, 2022

: error Not working yet

cannot set memory swappiness with cgroupv2: OCI runtime error

@d-513 d-513 marked this pull request as draft December 18, 2022 12:04
@DocMAX
Copy link

DocMAX commented Feb 24, 2023

: error Not working yet

cannot set memory swappiness with cgroupv2: OCI runtime error

I get that error too now on multiple containers. How can i fix this now?

@witten
Copy link

witten commented Apr 30, 2023

The ulimit thing may no longer be an issue in Podman 4.5.0+: containers/podman#18078

@adrianlzt
Copy link

Same error with podman version 5.2.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request] Support for Podman
4 participants