Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(clean): log removed/untagged images #1466

Merged
merged 1 commit into from
Apr 15, 2023
Merged

Conversation

piksel
Copy link
Member

@piksel piksel commented Nov 9, 2022

Add additional debug logging with the actual removed images (target image and any parent images) when running with --cleanup to help diagnosing left over images.

@piksel piksel requested a review from simskij as a code owner November 9, 2022 12:18
@codecov
Copy link

codecov bot commented Nov 9, 2022

Codecov Report

Patch coverage: 89.28% and project coverage change: +0.72 🎉

Comparison is base (dd1ec09) 66.75% compared to head (637114a) 67.47%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1466      +/-   ##
==========================================
+ Coverage   66.75%   67.47%   +0.72%     
==========================================
  Files          25       26       +1     
  Lines        2319     2346      +27     
==========================================
+ Hits         1548     1583      +35     
+ Misses        675      666       -9     
- Partials       96       97       +1     
Impacted Files Coverage Δ
pkg/container/client.go 46.19% <82.35%> (+4.89%) ⬆️
internal/util/rand_sha256.go 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@piksel piksel force-pushed the feat/log-clean-result branch from fdbbbe7 to 637114a Compare April 13, 2023 15:22
@piksel piksel merged commit 0a5bd54 into main Apr 15, 2023
@piksel piksel deleted the feat/log-clean-result branch April 15, 2023 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant