Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(notifications): add title field to template data #1125

Merged
merged 4 commits into from
Jan 5, 2022

Conversation

piksel
Copy link
Member

@piksel piksel commented Nov 5, 2021

This adds the field Title to the notification template data, so that it can be used inside the notification templates for services that doesn't normally have a way of displaying the title.
Note: This is only supported using the new templates (--notification-report)

Fixes #1052 (the second part) and fixes #1170.

@piksel piksel requested a review from simskij as a code owner November 5, 2021 11:42
@codecov
Copy link

codecov bot commented Nov 5, 2021

Codecov Report

Merging #1125 (0e52235) into main (1d59fb8) will increase coverage by 0.26%.
The diff coverage is 91.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1125      +/-   ##
==========================================
+ Coverage   62.02%   62.28%   +0.26%     
==========================================
  Files          23       23              
  Lines        1480     1485       +5     
==========================================
+ Hits          918      925       +7     
  Misses        476      476              
+ Partials       86       84       -2     
Impacted Files Coverage Δ
pkg/notifications/email.go 90.69% <66.66%> (-0.22%) ⬇️
pkg/notifications/notifier.go 77.35% <91.66%> (+5.35%) ⬆️
pkg/notifications/gotify.go 66.66% <100.00%> (ø)
pkg/notifications/msteams.go 66.66% <100.00%> (ø)
pkg/notifications/shoutrrr.go 74.39% <100.00%> (+0.97%) ⬆️
pkg/notifications/slack.go 94.87% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1d59fb8...0e52235. Read the comment docs.

@piksel piksel force-pushed the feat/tpl-title-field branch from ab69c75 to 0e52235 Compare January 5, 2022 09:39
@piksel piksel merged commit aa02d8d into main Jan 5, 2022
@piksel piksel deleted the feat/tpl-title-field branch January 5, 2022 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Server name in notifications Notifications via shoutrrr (telegram) do not include hostname
2 participants