Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Post update time out #1124

Merged
merged 4 commits into from
Nov 18, 2021
Merged

Conversation

patricegautier
Copy link
Contributor

Hi–

This simple PR is just to add a post update timeout option to the life cycle hooks, symmetric to the pre update timeout option that is there already.

I update the the documentation as well.

Thanks!

@codecov
Copy link

codecov bot commented Nov 5, 2021

Codecov Report

Merging #1124 (9544a4c) into main (0060cd6) will increase coverage by 0.39%.
The diff coverage is 71.42%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1124      +/-   ##
==========================================
+ Coverage   61.96%   62.35%   +0.39%     
==========================================
  Files          22       22              
  Lines        1438     1445       +7     
==========================================
+ Hits          891      901      +10     
+ Misses        463      458       -5     
- Partials       84       86       +2     
Impacted Files Coverage Δ
pkg/container/metadata.go 63.63% <ø> (ø)
pkg/container/container.go 51.92% <71.42%> (+6.56%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0060cd6...9544a4c. Read the comment docs.

@patricegautier
Copy link
Contributor Author

@simskij let me know if I need to do anything to unblock this one, thanks!

Copy link
Member

@simskij simskij left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Good job!

@simskij
Copy link
Member

simskij commented Nov 18, 2021

@all-contributors add @patricegautier for code

@simskij simskij merged commit b4a225c into containrrr:main Nov 18, 2021
@allcontributors
Copy link
Contributor

@simskij

I've put up a pull request to add @patricegautier! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants