-
Notifications
You must be signed in to change notification settings - Fork 883
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Post update time out #1124
Post update time out #1124
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1124 +/- ##
==========================================
+ Coverage 61.96% 62.35% +0.39%
==========================================
Files 22 22
Lines 1438 1445 +7
==========================================
+ Hits 891 901 +10
+ Misses 463 458 -5
- Partials 84 86 +2
Continue to review full report at Codecov.
|
…wer into PostUpdateTimeOut
@simskij let me know if I need to do anything to unblock this one, thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! Good job!
@all-contributors add @patricegautier for code |
I've put up a pull request to add @patricegautier! 🎉 |
Hi–
This simple PR is just to add a post update timeout option to the life cycle hooks, symmetric to the pre update timeout option that is there already.
I update the the documentation as well.
Thanks!