update dependencies (sane go.mod) #1061
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1061 +/- ##
==========================================
- Coverage 62.02% 61.96% -0.06%
==========================================
Files 22 22
Lines 1435 1438 +3
==========================================
+ Hits 890 891 +1
- Misses 462 463 +1
- Partials 83 84 +1
Continue to review full report at Codecov.
|
piksel
force-pushed
the
fix/mod-deps
branch
from
d96edcf to
b7a345b
Compare
piksel
commented
Sep 19, 2021
| func EncodeAuth(authConfig types.AuthConfig) (string, error) { | ||
| buf, err := json.Marshal(authConfig) | ||
| if err != nil { | ||
| return "", err |
There was a problem hiding this comment.
This basically cannot happen, since the passed struct is always serializable (which also makes it impossible to write a test for it). Still, it wouldn't be right to ignore the error, since something might change that makes it possible (or cosmic radiation etc) 🤷♀️
simskij
approved these changes
Sep 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this should both simplify the dependencies (and the go.mod), bring us closer to the current docker client and remove dependency on the old
runc(which is flagged as vulnerable by dependabot, even though the code is not used in watchtower itself).