Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OneShot Update #114

Closed
thelamer opened this issue Nov 29, 2017 · 4 comments
Closed

OneShot Update #114

thelamer opened this issue Nov 29, 2017 · 4 comments

Comments

@thelamer
Copy link
Contributor

Can you do oneshot upgrades on a running container IE:

docker run \ -v /var/run/docker.sock:/var/run/docker.sock \ --rm \ v2tec/watchtower container_to_watch --oneshot

Started making a helper container to achieve this and realized this should be trivial with your app, unless I am missing something.

@stffabi
Copy link
Contributor

stffabi commented Nov 30, 2017

Currently that's not possible. I like the idea and shouldn't be a big issue to implement that. Probably we should implement this as a breaking change. Normally it's a oneshot if no command line parameter is provided. If it should be run with a schedule, the schedule command line parameter has to be provided.

Any opinions on this?

@thelamer
Copy link
Contributor Author

I actually started digging into the code to make a fork maybe you could point me in the correct direction for what would be the correct place to add the os.exit(). I get adding the variable read and passing it to the upgrade command.

Also noticed the build process and Dockerfile are all external right now, not a huge deal, but just a comment that it does make it more difficult for an external user to create a pull request they know builds to get a change discussion started.

As far as this being the default behavior I assume you are asking other collaborators, but IMPO changing the default behavior on a widely deployed Docker container is not a good idea, many companies maintain internal documentation which probably just pulls latest and instructions would not sync even if github/dockerhub README was updated.

@thelamer
Copy link
Contributor Author

thelamer commented Dec 6, 2017

Created a pull request to get a discussion started #116

@simskij
Copy link
Member

simskij commented Apr 8, 2019

merged. closing

@simskij simskij closed this as completed Apr 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants