feat: use a more specific error type for no container info (#1115)

Co-authored-by: Jeremy L. Morris <[email protected]>
containrrr · Nov 12, 2021 · d9d6f79 · d9d6f79
1 parent ac00e48
commit d9d6f79
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 2 deletions.
diff --git a/pkg/container/container.go b/pkg/container/container.go
@@ -285,7 +285,7 @@ func (c Container) VerifyConfiguration() error {
 
 	containerInfo := c.ContainerInfo()
 	if containerInfo == nil {
-		return errorInvalidConfig
+		return errorNoContainerInfo
 	}
 
 	containerConfig := containerInfo.Config

diff --git a/pkg/container/container_test.go b/pkg/container/container_test.go
@@ -23,7 +23,7 @@ var _ = Describe("the container", func() {
 				c := mockContainerWithPortBindings()
 				c.containerInfo = nil
 				err := c.VerifyConfiguration()
-				Expect(err).To(Equal(errorInvalidConfig))
+				Expect(err).To(Equal(errorNoContainerInfo))
 			})
 		})
 		When("verifying a container with no config", func() {

diff --git a/pkg/container/errors.go b/pkg/container/errors.go
@@ -3,5 +3,6 @@ package container
 import "errors"
 
 var errorNoImageInfo = errors.New("no available image info")
+var errorNoContainerInfo = errors.New("no available container info")
 var errorNoExposedPorts = errors.New("exposed ports does not match port bindings")
 var errorInvalidConfig = errors.New("container configuration missing or invalid")