Fix CI for #897 #898
Merged
Fix CI for #897 #898
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HarryMichal
added
3. Bugfix
|
Build failed.
|
HarryMichal
added a commit
to HarryMichal/toolbox
that referenced
this pull request
Oct 21, 2021
HarryMichal
force-pushed
the
ci/fix-run-host-glibc
branch
from
abd69d8 to
ab8a33b
Compare
|
Build failed.
|
debarshiray
reviewed
Oct 21, 2021
HarryMichal
added a commit
to HarryMichal/toolbox
that referenced
this pull request
Oct 22, 2021
adjustmnets to the Toolbx binary that it requires presence of /run/host in both the host filesystem and the filesystem in a container. The presence of the directory is assured by systemd-tmpfiles by running it before the binary is started for the first time. This lead to the realization that the playbook structure is needlessly separated and can be unified as there is close to no benefit in keeping it separated. containers#898
HarryMichal
force-pushed
the
ci/fix-run-host-glibc
branch
from
ab8a33b to
29627f9
Compare
HarryMichal
added a commit
to HarryMichal/toolbox
that referenced
this pull request
Oct 22, 2021
adjustmnets to the Toolbx binary that it requires presence of /run/host in both the host filesystem and the filesystem in a container. The presence of the directory is assured by systemd-tmpfiles by running it before the binary is started for the first time. This lead to the realization that the playbook structure is needlessly separated and can be unified as there is close to no benefit in keeping it separated. containers#898
HarryMichal
force-pushed
the
ci/fix-run-host-glibc
branch
from
29627f9 to
c9294d8
Compare
HarryMichal
added a commit
to HarryMichal/toolbox
that referenced
this pull request
Oct 22, 2021
adjustmnets to the Toolbx binary that it requires presence of /run/host in both the host filesystem and the filesystem in a container. The presence of the directory is assured by systemd-tmpfiles by running it before the binary is started for the first time. This lead to the realization that the playbook structure is needlessly separated and can be unified as there is close to no benefit in keeping it separated. containers#898
HarryMichal
force-pushed
the
ci/fix-run-host-glibc
branch
from
c9294d8 to
2a5337a
Compare
|
Build succeeded.
|
HarryMichal
added a commit
to HarryMichal/toolbox
that referenced
this pull request
Oct 22, 2021
There is no significant benefit in keeping this configuration separated. Now the to-be installed packages are tracked in a single place and the test playbooks only call the relevant tests. This was pointed out by in 6063eb2 containers#898
HarryMichal
force-pushed
the
ci/fix-run-host-glibc
branch
from
2a5337a to
4476c72
Compare
|
Build failed.
|
There is no significant benefit in keeping this configuration separated. Now the to-be installed packages are tracked in a single place and the test playbooks only call the relevant tests. This was pointed out by in 6063eb2 containers#898
HarryMichal
force-pushed
the
ci/fix-run-host-glibc
branch
from
4476c72 to
b5d090b
Compare
|
Build failed.
|
PR containers#897 made adjustmnets to the Toolbx binary that it requires presence of /run/host in both the host filesystem and the filesystem in a container. The presence of the directory is assured by systemd-tmpfiles by running it before the binary is started for the first time. For the run to be effective 'data/tmpfiles.d/toolbox.conf' has to be installed in a location visible to systemd-tmpfiles. Therefore, the call to 'systemd-tmpfiles --create' had to be placed after the install step. containers#898
HarryMichal
force-pushed
the
ci/fix-run-host-glibc
branch
from
b5d090b to
83938f1
Compare
debarshiray
reviewed
Oct 24, 2021
|
Thanks for fixing the CI and the nice clean-up, @HarryMichal ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.