libc-wrappers: Ensure binaries built on Fedora 35 run on older Fedoras #829
Conversation
olivergs
force-pushed
the
wrap-pthread-glibc2.34
branch
from
b678d1f to
27605eb
Compare
|
Build failed.
|
|
Build failed.
|
HarryMichal
added
2. Under The Hood
|
recheck |
|
Build failed.
|
|
recheck |
|
This successfully works on my Fedora Silverblue Rawhide machine with |
|
Build succeeded.
|
|
Please, rebase without the test because it has been separated into #831 |
Seems I used a different branch and put the test there by accident. Rebasing. |
olivergs
force-pushed
the
wrap-pthread-glibc2.34
branch
from
f77b68a to
27605eb
Compare
|
Build succeeded.
|
|
anything preventing this from merging rn ? |
|
We are working on reviewing it and checking alternative approaches to fix this. |
A subsequent commit will add more wrappers to cover new symbol versions introduced in glibc-2.34. This will make it easier to read because it won't disrupt the rest of the build parameters. containers#821
There was a problem hiding this comment.
Thanks for working on this, @olivergs !
It would be good to mention the user-visible problem in the commit message, because the names of the wrapped functions is somewhat obvious from just looking at the commit. eg., the version of Fedora or glibc that triggered this issue.
debarshiray
force-pushed
the
wrap-pthread-glibc2.34
branch
from
27605eb to
95c1239
Compare
debarshiray
changed the title
|
Build succeeded.
|
debarshiray
force-pushed
the
wrap-pthread-glibc2.34
branch
from
95c1239 to
17e2ab7
Compare
|
Build succeeded.
|
A subsequent commit will add more wrappers to cover new symbol versions introduced in glibc-2.34. This will make it easier to read by clearly segregating the file into separate sections for each wrapper. containers#821
Recently, glibc-2.34, which is used by Fedora 35 onwards, added new
versions of the pthread_attr_getstacksize [1], pthread_create [2] and
pthread_detach [3] symbols as part of the libpthread removal
project [4]:
$ objdump -T /usr/bin/toolbox | grep GLIBC_2.34
...
0000000000000000 DF *UND* 0000000000000000 GLIBC_2.34
pthread_detach
0000000000000000 DF *UND* 0000000000000000 GLIBC_2.34
pthread_create
0000000000000000 DF *UND* 0000000000000000 GLIBC_2.34
pthread_attr_getstacksize
This means that /usr/bin/toolbox binaries built against glibc-2.34 on
newer Fedoras pick up the latest version of the symbols and fail to run
against older glibcs in older Fedoras.
[1] glibc commit ee092efed40d667b
https://sourceware.org/git/?p=glibc.git;a=commit;h=ee092efed40d667b
[2] glibc commit f47f1d91af985a90
https://sourceware.org/git/?p=glibc.git;a=commit;h=f47f1d91af985a90
[3] glibc commit df65f897e9501aa5
https://sourceware.org/git/?p=glibc.git;a=commit;h=df65f897e9501aa5
[4] https://sourceware.org/ml/libc-alpha/2019-10/msg00080.html
containers#821
debarshiray
force-pushed
the
wrap-pthread-glibc2.34
branch
from
17e2ab7 to
216314d
Compare
|
Build succeeded.
|
|
This fix is not complete. Trying to launch a toolbox container with this patch applied generates the following error message in the container entry-point: Either we try to fine-tune this patch or we'll have to use a different approach to fix this issue. |
|
recheck |
|
Build failed.
|
|
This approach of restricting the versions of the glibc symbols that are linked against isn't actually supported by glibc, and breaks if the early process start-up code changes. That's why it doesn't work with glibc-2.34, which is used by Fedora 35 onwards, because a new version of the |
|
Let's try #897 |
#821