cmd/root: Wire root command to 'enter' command #811
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HarryMichal
added
6. Major Change
|
Build failed.
|
debarshiray
reviewed
Jun 28, 2021
debarshiray
reviewed
Jun 29, 2021
debarshiray
reviewed
Jun 29, 2021
debarshiray
reviewed
Jun 29, 2021
This makes 'toolbox', without any commands specified, behave a lot like 'toolbox enter'. When there aren't any toolbox containers, it will offer to create a new container matching the same parameters passed to the command. If there's just one toolbox container available, then it will fall back to it. This makes the command line interface a lot similar to that of github.com/coreos/toolbox, which makes things easier for those switching over from it. Some changes by Debarshi Ray. containers#811
debarshiray
force-pushed
the
cmd/root/wire-toolbox-to-enter
branch
from
e8c2caf to
6c86cab
Compare
|
recheck |
|
Build failed.
|
|
recheck |
|
Thanks @debarshiray for the review and for the update. Appreciated! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One of requirements to get Toolbox to RHEL is to make the root command
('toolbox') have similar functionality as 'toolbox enter'.
Making 'toolbox' behave exactly the same as 'toolbox enter', making it
effectively an alias is not exactly desirable as the root command has
its own behaviour too. Instead,
toolboxonly translates totoolbox enterwhen no arguments or flags (excluding the global ones) areprovided.