cmd/list: Support images without names #800
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HarryMichal
added
6. Minor Change
HarryMichal
added a commit
to HarryMichal/toolbox
that referenced
this pull request
Jun 22, 2021
Some people create images manually. If such created images are recognize as toolbox images (they have the proper labels) but do not have a name/tag then 'toolbox list' will panic due to index being out of range. containers#800
HarryMichal
force-pushed
the
cmd/list/support-images-without-name
branch
from
ad58863 to
ef313fe
Compare
HarryMichal
added a commit
to HarryMichal/toolbox
that referenced
this pull request
Jun 22, 2021
Some people create images manually. If such created images are recognize as toolbox images (they have the proper labels) but do not have a name/tag then 'toolbox list' will panic due to index being out of range. containers#800
HarryMichal
force-pushed
the
cmd/list/support-images-without-name
branch
from
ef313fe to
e2426bd
Compare
Some people create images manually. If such created images are recognize as toolbox images (they have the proper labels) but do not have a name/tag then 'toolbox list' will panic due to index being out of range. containers#800
HarryMichal
force-pushed
the
cmd/list/support-images-without-name
branch
from
e2426bd to
f418dde
Compare
|
Works for me. Tests running Ok. Thanks! |
|
Build failed.
|
|
Build failed.
|
|
Thanks! Extra brownie points for adding a test. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some people create images manually. If such created images are recognize
as toolbox images (they have the proper labels) but do not have
a name/tag then 'toolbox list' will panic due to index being out of
range.