test/system: Bump secondary fedora image from 29 to 32 #780
+18
−28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HarryMichal
added
6. Minor Change
HarryMichal
added a commit
to HarryMichal/toolbox
that referenced
this pull request
May 26, 2021
The fedora-toolbox:32 image is the first of images in the renamed toolbox image repository[0]. With the change we can drop the pull_image_old() function because it was kept only for the old image. [0] containers#615 containers#780
HarryMichal
force-pushed
the
test/system/bump-minimal-fedora-image
branch
from
758f829 to
c6eb3ee
Compare
|
Build failed.
|
HarryMichal
added a commit
to HarryMichal/toolbox
that referenced
this pull request
May 28, 2021
The fedora-toolbox:32 image is the first of images in the renamed toolbox image repository[0]. With the change we can drop the pull_image_old() function because it was kept only for the old image. [0] containers#615 containers#780
HarryMichal
force-pushed
the
test/system/bump-minimal-fedora-image
branch
from
c6eb3ee to
24ff3f9
Compare
|
Build failed.
|
|
recheck |
|
Build failed.
|
|
recheck |
|
Build failed.
|
|
recheck |
|
Build failed.
|
|
recheck |
|
Build failed.
|
HarryMichal
added a commit
to HarryMichal/toolbox
that referenced
this pull request
May 31, 2021
The fedora-toolbox:32 image is the first of images in the renamed toolbox image repository[0]. With the change we can drop the pull_image_old() function because it was kept only for the old image. [0] containers#615 containers#780
HarryMichal
force-pushed
the
test/system/bump-minimal-fedora-image
branch
from
24ff3f9 to
bf3c911
Compare
The fedora-toolbox:32 image is the first of images in the renamed toolbox image repository[0]. With the change we can drop the pull_image_old() function because it was kept only for the old image. Seems like newer version of ShellCheck checks the validity of variable names (SC2153). This caused a false positive, so I silenced it. [0] containers#615 containers#780
|
Build failed.
|
HarryMichal
force-pushed
the
test/system/bump-minimal-fedora-image
branch
from
bf3c911 to
c5b9ea6
Compare
|
Build succeeded.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The fedora-toolbox:32 image is the first of images in the renamed
toolbox image repository[0]. With the change we can drop the
pull_image_old() function because it was kept only for the old image.
[0] #615