test/system: Use env var for invoking Toolbox #777
Conversation
The system test refactor[0] replaced the 'run_toolbox' helper function with 'run toolbox', which is a normal invocation of Toolbox. This makes it impossible to override Toolbox used during the tests using env var. [0] containers#693
HarryMichal
added
6. Minor Change
|
Build failed.
|
|
recheck |
|
Build succeeded.
|
There was a problem hiding this comment.
Thanks for cleaning this up!
The commit message is missing a link to this PR, though. It's possible to find it by looking up the commit in GitHub's web interface, but that's one extra step that starts to become a hassle after some time.
Also, when referring to other commits in the commit message, it's convenient to include the actual commit ID. Only having the link to the pull request or the issue makes one go through a few more hoops to look at the commit - open the PR or issue in the browser, and look at the commit in the GitHub UI. Given that the reader was looking at the original commit in the terminal, having to switch back and forth between the terminal and browser becomes annoying - the GitHub UI and raw Git formats the commits differently, etc.. It's not impossible but the minor irrations begin to add up. :)
Here are some patterns that I find a bit more convenient:
In short, we write the commit message only once; but in case someone looks it up later, that's usually because the person is either trying to quickly audit the changes in a new release or hunting a bug, and in those cases it's really worth taking the extra trouble to make it easy for the reader.
The system test refactor[0] replaced the 'run_toolbox' helper function
with 'run toolbox', which is a normal invocation of Toolbox. This makes
it impossible to override Toolbox used during the tests using env var.
[0] #693