src/create: Handle read-only /boot #712
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HarryMichal
added
6. Minor Change
HarryMichal
added
2. Container Configuration
|
Build succeeded.
|
|
In the future, we will likely take inspiration from https://github.com/cgwalters/coretoolbox and instead of cherry-picking parts of the host filesystem mount the whole To explain, this change would allow us to make the code for the |
CoreOS recently made /boot read-only[0]. This caused an issue with starting containers because /boot was mounted only with option rslave but missed the ro option. This caused a permission issue. This scenario is very similar to the one with /usr on Fedora Silverblue. The solution for this is to check mount options of the path and check if it uses the rw option or ro and then add it to the mount options in the --volume option in 'podman create'. Fixes: coreos/fedora-coreos-tracker#734 [0] coreos/fedora-coreos-config@1de21ff containers#712
HarryMichal
force-pushed
the
fix/readonly-boot-coreos
branch
from
c3bd4ce to
e61aa47
Compare
|
Build succeeded.
|
debarshiray
reviewed
Jun 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CoreOS recently made /boot read-only[0]. This caused an issue with starting containers because /boot was mounted only with option rslave but missed the ro option. This caused a permission issue.
This scenario is very similar to the one with /usr on Fedora Silverblue. The solution for this is to check mount options of the path and check if it uses the rw option or ro and then add it to the mount options in the --volume option in 'podman create'.
Fixes: coreos/fedora-coreos-tracker#734
coreos/fedora-coreos-config@1de21ff
Situation on CoreOS
This, sadly, does not fix existing containers on CoreOS because the configuration of existing containers can not be changed. The only way to get this fix is to recreate toolboxes.