Pass XAUTHORITY environment variable to container #572
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build failed.
|
debarshiray
requested changes
Oct 22, 2020
There was a problem hiding this comment.
Thanks for working on this. The patch looks good, but the commit message needs some work:
- Would be better if you used a real email address instead of
[email protected] - Prefix the subject of the commit with
pkg/utils:and mention X11 clients instead of GUI programs - Link to this pull request
debarshiray
pushed a commit
to likan999/ppa-toolbox
that referenced
this pull request
Oct 27, 2020
|
Build failed.
|
|
I was playing around with this a bit today, and I realized that we need to add the package that provides Otherwise, if |
It's necessary to propagate the XAUTHORITY environment variable from the host when an X11 client is run as 'sudo <some-client>'. If an X11 client is started inside a 'su -' session, then xauth(1) needs to be present so that pam_xauth.so can add a new XAUTHORITY environment variable to the 'su -' session. containers#572
|
Oops I should've addressed the review comments myself. @debarshiray thanks for improving the PR. |
likan999
added a commit
to likan999/ppa-toolbox
that referenced
this pull request
Oct 30, 2020
It's necessary to propagate the XAUTHORITY environment variable from the host when an X11 client is run as 'sudo <some-client>'. If an X11 client is started inside a 'su -' session, then xauth(1) needs to be present so that pam_xauth.so can add a new XAUTHORITY environment variable to the 'su -' session. containers#572
My pleasure. Thank you for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On system that uses this instead of ~/.Xauthority, this is need to make sure the container can run X programs.