Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/run: Adjust for changes in 'podman ps' in Podman 2.0 #509

Conversation

debarshiray
Copy link
Member

The key containing the container's name (ie., "Names") is no longer a
string, but a slice of strings.

The key containing the container's name (ie., "Names") is no longer a
string, but a slice of strings.

containers#509
@debarshiray debarshiray force-pushed the wip/rishi/enter-unbreak-fallback-to-only-container branch from 78e8877 to 06ef424 Compare July 23, 2020 13:28
@debarshiray
Copy link
Member Author

I wish we had tests for the enter command, but I guess it's hard to drive it non-interactively as part of a test-suite. This code path is part of the fallback we have when there's only one toolbox container, but it's not the default, and toolbox enter shows a message and continues to use it without requiring any arguments.

I am also looking forward to #503 which will make the JSON parsing a lot nicer. :)

@softwarefactory-project-zuul
Copy link

Build failed.

@HarryMichal
Copy link
Member

I wish we had tests for the enter command, but I guess it's hard to drive it non-interactively as part of a test-suite. This code path is part of the fallback we have when there's only one toolbox container, but it's not the default, and toolbox enter shows a message and continues to use it without requiring any arguments.

It is possible to do it even if it is not interactive. I slimmed the CI considerably in #375 mainly due to problems with pulling images that caused the CI to flake a lot (#372). Currently, bats does not clean between test cases to save bandwidth and time. We could break that pattern and make the tests more complicated.

@HarryMichal HarryMichal added this to the Release 0.1.0 milestone Jul 23, 2020
@debarshiray debarshiray merged commit 06ef424 into containers:master Jul 23, 2020
@debarshiray debarshiray deleted the wip/rishi/enter-unbreak-fallback-to-only-container branch July 23, 2020 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants