Disable detach-keys #396
Closed
Disable detach-keys #396
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build failed.
|
HarryMichal
added
3. Enhancement
HarryMichal
pushed a commit
to HarryMichal/toolbox
that referenced
this pull request
Jul 28, 2020
Podman sets keys 'ctrl-p' and 'ctrl-q' as the default detach keys. This behaviour is not desirable in Toolbox. Since Podman v1.8.2[0] it is possible to have set no detach keys by passing an empty string to the --detach-keys option. Thanks to this the 'Ctrl+p' and 'Ctrl-q' combinations are doing what they should do normally in a terminal. [0] containers/podman#5203 Fixes: containers#394 containers#396
HarryMichal
pushed a commit
to HarryMichal/toolbox
that referenced
this pull request
Jul 28, 2020
Podman sets keys 'ctrl-p' and 'ctrl-q' as the default detach keys. This behaviour is not desirable in Toolbox. Since Podman v1.8.2[0] it is possible to have set no detach keys by passing an empty string to the --detach-keys option. Thanks to this the 'Ctrl+p' and 'Ctrl-q' combinations are doing what they should do normally in a terminal. [0] containers/podman#5203 Fixes: containers#394 containers#396
|
Hi @EnigmaCurry! I apologize for prematurely closing your PR. I wanted to update it to make it work with the latest version of Toolbox (it has been rewritten in Go) but I messed up. I'll open a new PR from my branch where I have your original commit that I've updated. You're still it's original author, so git statistics magic should give the credit to you :). Thank you for your work! |
HarryMichal
pushed a commit
to HarryMichal/toolbox
that referenced
this pull request
Jul 28, 2020
Podman sets keys 'ctrl-p' and 'ctrl-q' as the default detach keys. This behaviour is not desirable in Toolbox. Since Podman v1.8.2[0] it is possible to have set no detach keys by passing an empty string to the --detach-keys option. Thanks to this the 'Ctrl+p' and 'Ctrl-q' combinations are doing what they should do normally in a terminal. [0] containers/podman#5203 Fixes: containers#394 containers#396
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the problem of not being able to use the Ctrl-p shortcut in readline and Emacs. This disables the podman detach-keys (default Ctrl-p, Ctrl-q). Without this, things like bash readline, and Emacs suffer from not being able to use Ctrl-p key.
I don't know if there is any good reason to actually enable detach keys when using toolbox. If so, then this should be made configurable somehow, but I thought I would share my fix regardless. Thanks!
This fixes #394