Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add list command #39

Merged
merged 1 commit into from
Feb 12, 2019
Merged

Add list command #39

merged 1 commit into from
Feb 12, 2019

Conversation

ozoder
Copy link
Contributor

@ozoder ozoder commented Jan 16, 2019

Add the list command providing the possibility to list all images and containers created by fedora-toolbox (i.e those that have the "com.redhat.component=fedora-toolbox" label). Two flags can be used: --images and --containers, to list only images or containers. If none of these flags is used, the command lists both. Additionally, containers that are currently running are highlighted by green color.

@debarshiray
Copy link
Member

@owtaylor do you have any comments about the formatting of the output, etc.?

Copy link
Member

@debarshiray debarshiray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, @ozoder One quick question:

fedora-toolbox Outdated Show resolved Hide resolved
Copy link
Member

@debarshiray debarshiray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have been using the list command for the past few days. It's really nice!

Some comments after that experience:

fedora-toolbox Outdated Show resolved Hide resolved
fedora-toolbox Outdated Show resolved Hide resolved
fedora-toolbox Outdated Show resolved Hide resolved
fedora-toolbox Outdated Show resolved Hide resolved
Copy link
Member

@debarshiray debarshiray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some small nitpicky things about POSIX correctness:

fedora-toolbox Outdated Show resolved Hide resolved
fedora-toolbox Outdated Show resolved Hide resolved
fedora-toolbox Outdated Show resolved Hide resolved
fedora-toolbox Outdated Show resolved Hide resolved
@debarshiray
Copy link
Member

I took the liberty to make the above changes for POSIX compatibility, and was able to use column to make podman ps work without table. Looks like it works with both podman.git master and podman-1.0.0.

@debarshiray debarshiray merged commit 5e4e63a into containers:master Feb 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants