Check /usr/share/profile.d when bind mounting toolbox.sh #362
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
debarshiray
pushed a commit
to debarshiray/toolbox
that referenced
this pull request
Jan 13, 2020
/usr/share/profile.d is the default location where toolbox.sh is installed, even though, in practice, most (all?) distributions use /etc/profile.d. It's reasonable to at least make the code work with the default build values. containers#362
debarshiray
force-pushed
the
wip/rishi/usr-share-profile.d-toolbox.sh
branch
from
a2ab989 to
3bf4c3e
Compare
/usr/share/profile.d is the default location where toolbox.sh is installed, even though, in practice, most (all?) distributions use /etc/profile.d. It's reasonable to at least make the code work with the default build values. containers#362
|
I split this out from @HarryMichal 's branch for hhttps://github.com//pull/250 |
debarshiray
commented
Jan 14, 2020
debarshiray
force-pushed
the
wip/rishi/usr-share-profile.d-toolbox.sh
branch
from
3bf4c3e to
8f40702
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/usr/share/profile.d is the default location where toolbox.sh is
installed, even though, in practice, most (all?) distributions use
/etc/profile.d. It's reasonable to at least make the code work with the
default build values.