Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import cgwalters/coretoolbox, add `TOOLBOX_VARIANT option #319

Closed

Conversation

cgwalters
Copy link
Collaborator

This is per the decision to merge the projects. Add a mechanism
to "dispatch" transiently or persistently to /usr/libexec/toolbox-rs
so people can easily try it out.

Basically: mkdir -p ~/.config/toolbox && echo rs > ~/.config/toolbox/variant

We'll ship both, and then a 3rd new version later.

@cgwalters cgwalters mentioned this pull request Oct 31, 2019
@@ -35,3 +35,11 @@ endif
subdir('data')
subdir('doc')
subdir('profile.d')

#mytarget = custom_target('toolbox-rs',
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know meson, tried only briefly to figure out how to glue this together but we can just stick it in the spec file or wrap it in a Makefile.

This is per the decision to merge the projects.  Add a mechanism
to "dispatch" transiently or persistently to `/usr/libexec/toolbox-rs`
so people can easily try it out.

Basically: `mkdir -p ~/.config/toolbox && echo rs > ~/.config/toolbox/variant`

We'll ship both, and then a 3rd new version later.
@cgwalters cgwalters force-pushed the import-coretoolbox-direct branch from 121796c to 2363ca2 Compare October 31, 2019 15:44
@cgwalters cgwalters mentioned this pull request Oct 31, 2019
@debarshiray
Copy link
Member

Does the Rust code actually work?

I had tried coretoolbox in the past with older Podman versions (eg., podman-1.6.2-2.fc30 and a few builds older than that) and toolbox run kept erroring out for me on Fedora. Today I tried again with podman-1.7.0-0.4.rc2.fc31.x86_64 and got:

$ ~/.cargo/bin/toolbox-rs run
mount: /home/rishi: special device /host/home/rishi does not exist.
error: Initializing container (static): Child ["mount" "--rbind" "/host/home/rishi" "/home/rishi"] exited: exit code: 32
Error: non zero exit code: 1: OCI runtime error

I don't recall if this is the exact same error as the ones with older Podman versions, but I can try again, if you want.

(Sorry, I thought I had already left a comment some weeks back, but apparently I didn't.)

@debarshiray
Copy link
Member

It's the same error that @HarryMichal reported in cgwalters/coretoolbox#3 (comment)

@njam
Copy link

njam commented May 1, 2020

Ha! I didn't know there's a version written in Rust. I like run_pid1().

I implemented my own experimental version in Rust: https://gitlab.com/njam/toolbox-njam
It's not 1:1 feature compatible, rather I'm using it to experiment with some ideas (like mounting working directories other than $HOME).

Anyways, looking forward to the Go-rewrite, hopefully once done new features and bug fixes can be implemented in toolbox :)

Base automatically changed from master to main March 25, 2021 22:25
@debarshiray
Copy link
Member

The Go version of Toolbox is alive and thriving. So I don't think this is relevant anymore.

Please feel free to re-open if you have reason to think otherwise.

@debarshiray debarshiray closed this Jul 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants