-
Notifications
You must be signed in to change notification settings - Fork 220
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Import cgwalters/coretoolbox, add `TOOLBOX_VARIANT option #319
Conversation
@@ -35,3 +35,11 @@ endif | |||
subdir('data') | |||
subdir('doc') | |||
subdir('profile.d') | |||
|
|||
#mytarget = custom_target('toolbox-rs', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know meson, tried only briefly to figure out how to glue this together but we can just stick it in the spec file or wrap it in a Makefile
.
This is per the decision to merge the projects. Add a mechanism to "dispatch" transiently or persistently to `/usr/libexec/toolbox-rs` so people can easily try it out. Basically: `mkdir -p ~/.config/toolbox && echo rs > ~/.config/toolbox/variant` We'll ship both, and then a 3rd new version later.
121796c
to
2363ca2
Compare
Does the Rust code actually work? I had tried
I don't recall if this is the exact same error as the ones with older Podman versions, but I can try again, if you want. (Sorry, I thought I had already left a comment some weeks back, but apparently I didn't.) |
It's the same error that @HarryMichal reported in cgwalters/coretoolbox#3 (comment) |
Ha! I didn't know there's a version written in Rust. I like I implemented my own experimental version in Rust: https://gitlab.com/njam/toolbox-njam Anyways, looking forward to the Go-rewrite, hopefully once done new features and bug fixes can be implemented in toolbox :) |
The Go version of Toolbox is alive and thriving. So I don't think this is relevant anymore. Please feel free to re-open if you have reason to think otherwise. |
This is per the decision to merge the projects. Add a mechanism
to "dispatch" transiently or persistently to
/usr/libexec/toolbox-rs
so people can easily try it out.
Basically:
mkdir -p ~/.config/toolbox && echo rs > ~/.config/toolbox/variant
We'll ship both, and then a 3rd new version later.