test/system: Miscellaneous improvements to the 'list' tests (2) #1273
Conversation
The long options are easier to grep(1) for in the sources than their shorter aliases. containers#1273
debarshiray
force-pushed
the
wip/rishi/test-system-list-names
branch
from
0e8f294 to
1d5e897
Compare
|
Build succeeded. ✔️ unit-test SUCCESS in 9m 06s |
Currently, some of the names of the tests were too long, and had inconsistent and verbose wording. This made it difficult to look at them and get a gist of all the scenarios being tested. The names are like headings. They shouldn't be too long, should capture the primary objective of the test and be consistent in their wording. containers#1273
|
Build succeeded. ✔️ unit-test SUCCESS in 9m 14s |
|
Build succeeded. ✔️ unit-test SUCCESS in 9m 04s |
Fedora 35 was stuck with Bats 1.5.0. However, it reached End of Life on 13th December 2022 and was dropped from the CI [1]. Fedora 36 is the oldest supported Fedora and it has Bats 1.8.2. Therefore, there's no need to retain compatibility with Bats < 1.7.0. Note that bats_require_minimum_version itself is only available from Bats 1.7.0 [2]. [1] Commit 419e4e8 containers#1237 [2] Bats commit 71d6b71cebc3d32b bats-core/bats-core#556 https://bats-core.readthedocs.io/en/stable/warnings/BW02.html containers#1273
debarshiray
force-pushed
the
wip/rishi/test-system-list-names
branch
from
322b373 to
0553b7f
Compare
|
Build succeeded. ✔️ unit-test SUCCESS in 8m 52s |
Currently, some of the names of the tests were too long, and had inconsistent and verbose wording. This made it difficult to look at them and get a gist of all the scenarios being tested. The names are like headings. They shouldn't be too long, should capture the primary objective of the test and be consistent in their wording. containers#1273
Fedora 35 was stuck with Bats 1.5.0. However, it reached End of Life on 13th December 2022 and was dropped from the CI [1]. Fedora 36 is the oldest supported Fedora and it has Bats 1.8.2. Therefore, there's no need to retain compatibility with Bats < 1.7.0. Note that bats_require_minimum_version itself is only available from Bats 1.7.0 [2]. [1] Commit 419e4e8 containers#1237 [2] Bats commit 71d6b71cebc3d32b bats-core/bats-core#556 https://bats-core.readthedocs.io/en/stable/warnings/BW02.html containers#1273
debarshiray
force-pushed
the
wip/rishi/test-system-list-names
branch
from
c35eacf to
1ba95dd
Compare
|
Build succeeded. ✔️ unit-test SUCCESS in 9m 05s |
A subsequent commit will add a variant of this test that uses 'list' without the '--images' option. containers#1273
Currently, some of the names of the tests were too long, and had inconsistent and verbose wording. This made it difficult to look at them and get a gist of all the scenarios being tested. The names are like headings. They shouldn't be too long, should capture the primary objective of the test and be consistent in their wording. containers#1273
|
Build succeeded. ✔️ unit-test SUCCESS in 10m 21s |
Fedora 35 was stuck with Bats 1.5.0. However, it reached End of Life on 13th December 2022 and was dropped from the CI [1]. Fedora 36 is the oldest supported Fedora and it has Bats 1.8.2. Therefore, there's no need to retain compatibility with Bats < 1.7.0. Note that bats_require_minimum_version itself is only available from Bats 1.7.0 [2]. [1] Commit 419e4e8 containers#1237 [2] Bats commit 71d6b71cebc3d32b bats-core/bats-core#556 https://bats-core.readthedocs.io/en/stable/warnings/BW02.html containers#1273
debarshiray
force-pushed
the
wip/rishi/test-system-list-names
branch
from
ff38826 to
e741215
Compare
debarshiray
changed the title
|
Build succeeded. ✔️ unit-test SUCCESS in 9m 51s |
A subsequent commit will add a variant of this test that uses 'list' without the '--images' option. containers#1273
|
Build succeeded. ✔️ unit-test SUCCESS in 9m 54s |
|
Build succeeded. ✔️ unit-test SUCCESS in 8m 07s |
This is the 'simple' case of having a well-known named Toolbx image (ie., not a copy, not an image without a name, not a non-Toolbx image). It's good to ensure that the default image works as expected with 'list' before moving on to more complex scenarios. containers#1273
This is the 'simple' case of having a well-known Toolbx image (ie., not a copy, not an image without a name, not a non-Toolbx image). It's good to ensure that the default image works as expected with 'list' before moving on to more complex scenarios. containers#1273
It's good to ensure that older well-known Toolbx images continue to work with newer versions of 'list'. containers#1273
debarshiray
force-pushed
the
wip/rishi/test-system-list-names
branch
from
476153c to
c13e424
Compare
|
Build succeeded. ✔️ unit-test SUCCESS in 8m 58s |
It's good to ensure that older well-known Toolbx images continue to work with newer versions of 'list'. containers#1273
debarshiray
changed the title
This restores parts of commit e09de9f. containers#1273
debarshiray
force-pushed
the
wip/rishi/test-system-list-names
branch
from
c13e424 to
f3a60e8
Compare
|
Build succeeded. ✔️ unit-test SUCCESS in 8m 06s |
debarshiray
force-pushed
the
wip/rishi/test-system-list-names
branch
from
f3a60e8 to
55bf3d0
Compare
|
Build succeeded. ✔️ unit-test SUCCESS in 9m 14s |
|
Build succeeded. ✔️ unit-test SUCCESS in 10m 26s |
This is a quick sanity check with 'podman images' to ensure that all the images are in place before running 'list'. Other tests already do this, so this change makes these two tests consistent with the rest. containers#1273
|
Build succeeded. ✔️ unit-test SUCCESS in 9m 19s |
|
Build succeeded. ✔️ unit-test SUCCESS in 8m 46s |
debarshiray
force-pushed
the
wip/rishi/test-system-list-names
branch
from
701ce32 to
44cbdb1
Compare
|
Build succeeded. ✔️ unit-test SUCCESS in 8m 49s |
Now that Toolbx offers built-in support for Ubuntu containers [1], it makes sense to test that it works well on Ubuntu hosts. Ubuntu 22.04 is the latest long term support (or LTS) release [2] from Ubuntu, and GitHub provides runners for GitHub workflows [3]. Ubuntu 22.04 only has Bats 1.2.1 [4], while Toolbx requires 1.7.0 [5]; and Shadow 4.8 [6], while libsubid.so was introduced in Shadow 4.9 [7]. Hence, newer versions of these dependencies need to be built to run the tests. Note that a separate sub-directory inside $GITHUB_WORKSPACE [8] is used for Toolbx itself to prevent codespell from getting triggered by problems in the dependencies themselves [9]. [1] Commit a84a358 containers#483 containers#1284 [2] https://wiki.ubuntu.com/Releases [3] https://docs.github.com/en/actions/using-github-hosted-runners/about-github-hosted-runners [4] https://packages.ubuntu.com/jammy/bats [5] Commit e22a82f containers#1273 [6] https://packages.ubuntu.com/source/jammy/shadow https://packages.ubuntu.com/source/jammy-updates/shadow [7] Shadow commit 0a7888b1fad613a0 shadow-maint/shadow@0a7888b1fad613a0 shadow-maint/shadow#154 [8] https://docs.github.com/en/actions/learn-github-actions/variables [9] bats-core/bats-core#743 containers#1319
Now that Toolbx offers built-in support for Ubuntu containers [1], adding an Ubuntu host to the upstream CI will help ensure that Toolbx continues to work well on Ubuntu. Ubuntu 22.04 is the latest long term support (or LTS) release [2] from Ubuntu, and GitHub provides runners for GitHub workflows [3]. Ubuntu 22.04 only has Bats 1.2.1 [4], while Toolbx requires 1.7.0 [5]; and Shadow 4.8 [6], while libsubid.so was introduced in Shadow 4.9 [7]. Hence, newer versions of these dependencies need to be built to run the tests. Note that a separate sub-directory inside $GITHUB_WORKSPACE [8] is used for Toolbx itself to prevent codespell from getting triggered by problems in the dependencies themselves [9]. [1] Commit a84a358 containers#483 containers#1284 [2] https://wiki.ubuntu.com/Releases [3] https://docs.github.com/en/actions/using-github-hosted-runners/about-github-hosted-runners [4] https://packages.ubuntu.com/jammy/bats [5] Commit e22a82f containers#1273 [6] https://packages.ubuntu.com/source/jammy/shadow https://packages.ubuntu.com/source/jammy-updates/shadow [7] Shadow commit 0a7888b1fad613a0 shadow-maint/shadow@0a7888b1fad613a0 shadow-maint/shadow#154 [8] https://docs.github.com/en/actions/learn-github-actions/variables [9] bats-core/bats-core#743 containers#1319
Now that Toolbx offers built-in support for Ubuntu containers [1], adding an Ubuntu host to the upstream CI will help ensure that Toolbx continues to work well on Ubuntu. Ubuntu 22.04 is the latest long term support (or LTS) release [2] from Ubuntu, and GitHub provides runners for GitHub workflows [3]. Ubuntu 22.04 only has Bats 1.2.1 [4], while Toolbx requires 1.7.0 [5]; and Shadow 4.8 [6], while libsubid.so was introduced in Shadow 4.9 [7]. Hence, newer versions of these dependencies need to be built to run the tests. Note that a separate sub-directory inside $GITHUB_WORKSPACE [8] is used for Toolbx itself to prevent codespell from getting triggered by problems in the dependencies themselves [9]. [1] Commit a84a358 containers#483 containers#1284 [2] https://wiki.ubuntu.com/Releases [3] https://docs.github.com/en/actions/using-github-hosted-runners/about-github-hosted-runners [4] https://packages.ubuntu.com/jammy/bats [5] Commit e22a82f containers#1273 [6] https://packages.ubuntu.com/source/jammy/shadow https://packages.ubuntu.com/source/jammy-updates/shadow [7] Shadow commit 0a7888b1fad613a0 shadow-maint/shadow@0a7888b1fad613a0 shadow-maint/shadow#154 [8] https://docs.github.com/en/actions/learn-github-actions/variables [9] bats-core/bats-core#743 containers#1319
Now that Toolbx offers built-in support for Ubuntu containers [1], adding an Ubuntu host to the upstream CI will help ensure that Toolbx continues to work well on Ubuntu. Ubuntu 22.04 is the latest long term support (or LTS) release [2] from Ubuntu, and GitHub provides runners for GitHub workflows [3]. Ubuntu 22.04 only has Bats 1.2.1 [4], while Toolbx requires 1.7.0 [5]; and Shadow 4.8 [6], while libsubid.so was introduced in Shadow 4.9 [7]. Hence, newer versions of these dependencies need to be built to run the tests. Note that a separate sub-directory inside $GITHUB_WORKSPACE [8] is used for Toolbx itself to prevent codespell from getting triggered by problems in the dependencies themselves [9]. [1] Commit a84a358 containers#483 containers#1284 [2] https://wiki.ubuntu.com/Releases [3] https://docs.github.com/en/actions/using-github-hosted-runners/about-github-hosted-runners [4] https://packages.ubuntu.com/jammy/bats [5] Commit e22a82f containers#1273 [6] https://packages.ubuntu.com/source/jammy/shadow https://packages.ubuntu.com/source/jammy-updates/shadow [7] Shadow commit 0a7888b1fad613a0 shadow-maint/shadow@0a7888b1fad613a0 shadow-maint/shadow#154 [8] https://docs.github.com/en/actions/learn-github-actions/variables [9] bats-core/bats-core#743 containers#1319
Now that Toolbx offers built-in support for Ubuntu containers [1], adding an Ubuntu host to the upstream CI will help ensure that Toolbx continues to work well on Ubuntu. Ubuntu 22.04 is the latest long term support (or LTS) release [2] from Ubuntu, and is the latest Ubuntu version that GitHub provides runners for [3]. Ubuntu 22.04 only has Bats 1.2.1 [4], while Toolbx requires 1.7.0 [5]; and Shadow 4.8 [6], while Toolbx requires 4.9 because it needs libsubid.so [7,8]. Hence, newer versions of these dependencies need to be built to run the tests. The build flags for Shadow were taken from the Debian package [9]. A separate sub-directory inside $GITHUB_WORKSPACE [10] is used for Toolbx itself to prevent codespell from getting triggered by spelling mistakes in these dependencies themselves [11]. Unfortunately, the SHELL environment variable goes mysteriously missing from the runtime environment of the GitHub Actions workflow [12]. This breaks the 'create' and 'enter' commands, and therefore tests involving them can't be run until this is resolved. Meanwhile, running the CI on Ubuntu with a subset of the tests, is still better than not running the CI on Ubuntu at all. [1] Commit a84a358 containers#483 containers#1284 [2] https://wiki.ubuntu.com/Releases [3] https://docs.github.com/en/actions/using-github-hosted-runners/about-github-hosted-runners [4] https://packages.ubuntu.com/jammy/bats [5] Commit e22a82f containers#1273 [6] https://packages.ubuntu.com/source/jammy/shadow https://packages.ubuntu.com/source/jammy-updates/shadow [7] Shadow commit 0a7888b1fad613a0 shadow-maint/shadow@0a7888b1fad613a0 shadow-maint/shadow#154 [8] Commit ca8007c containers#1074 [9] https://salsa.debian.org/debian/shadow/ [10] https://docs.github.com/en/actions/learn-github-actions/variables [11] bats-core/bats-core#743 [12] https://github.com/orgs/community/discussions/59413 containers#1319
No description provided.