Some minor tweaks to the 'toolbox create --authfile ...' code #1240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The rest of the manual refers to the file passed to the --authfile option as FILE, not AUTHFILE. Fallout from ecd1ced containers#1240
debarshiray
force-pushed
the
wip/rishi/authfile-style-fixes
branch
from
35c5139 to
48c07b8
Compare
|
Build succeeded. ✔️ unit-test SUCCESS in 9m 01s |
It's better not to use the global flag variables beyond the top-level RunE functions, because sometimes the lower-level functions are re-used from other files within the 'cmd' package. In this case, createContainer(), and hence pullImage(), is also used in src/cmd/run.go to implement the 'run' command. However, the 'run' command doesn't have a --authflags option. Since the default value of the flag is the zero value of the type, which is a NOP in the code, it's likely that the code was still correct, but it will be better to maintain some discipline here to highlight the inputs needed by the lower-level functions. Otherwise, things can get tangled up. Fallout from ecd1ced containers#1240
|
Build succeeded. ✔️ unit-test SUCCESS in 9m 13s |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.