Enhance subid check by using library function #1184
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Error correctly if no ranges found Add subid-devel dependency for zuul Refactor subid check to move cgo glue elsewhere Signed-off-by: Martin Jackson <[email protected]>
|
Build succeeded. ✔️ unit-test SUCCESS in 8m 08s |
|
This will fix #1074 and fedora-silverblue/issue-tracker#263 and is the final form of #1180 where there is more discussion of what and why. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Error correctly if no ranges found
Add subid-devel dependency for zuul
Refactor subid check to move cgo glue elsewhere
Signed-off-by: Martin Jackson [email protected]