Move image caching from Zuul playbook #751
Labels
1. Feature request
A request for a new feature
2. CI
Automation of testing, analysis and other actions
2. Testing
Related to testing of Toolbox - unit, system,..
Milestone
Comments
HarryMichal
added
1. Feature request
debarshiray
added a commit
to debarshiray/toolbox
that referenced
this issue
Jun 21, 2023
The 000-setup.bats and 999-teardown.bats files were added [1] at a time
when Bats didn't offer any hooks for suite-wide setup and teardown.
That changed in Bats 1.7.0, which introduced the setup_suite and
teardown_suite hooks. These hooks make it easier to run a subset of the
tests, which is a good thing.
In the past, to run a subset of the tests, one had to do:
$ bats ./test/system/000-setup.bats ./test/system/002-help.bats \
./test/system/999-teardown.bats
Now, one only has to do:
$ bats ./test/system/002-help.bats
Commit e22a82f already added a dependency on Bats >= 1.7.0.
Therefore, it should be exploited wherever possible to simplify things.
[1] Commit 54a2ca1
containers#751
[2] Bats commit fb467ec3f04e322a
bats-core/bats-core#39
https://bats-core.readthedocs.io/en/stable/writing-tests.html
debarshiray
added a commit
to debarshiray/toolbox
that referenced
this issue
Jun 21, 2023
The 000-setup.bats and 999-teardown.bats files were added [1] at a time
when Bats didn't offer any hooks for suite-wide setup and teardown.
That changed in Bats 1.7.0, which introduced the setup_suite and
teardown_suite hooks. These hooks make it easier to run a subset of the
tests, which is a good thing.
In the past, to run a subset of the tests, one had to do:
$ bats ./test/system/000-setup.bats ./test/system/002-help.bats \
./test/system/999-teardown.bats
Now, one only has to do:
$ bats ./test/system/002-help.bats
Commit e22a82f already added a dependency on Bats >= 1.7.0.
Therefore, it should be exploited wherever possible to simplify things.
[1] Commit 54a2ca1
containers#751
[2] Bats commit fb467ec3f04e322a
bats-core/bats-core#39
https://bats-core.readthedocs.io/en/stable/writing-tests.html
containers#1317
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Is your feature request related to a problem? Please describe.
Since #517 we have a mechanism for caching OCI images for greater CI reliability. This mechanism is part of the CI configuration and thus can not be utilized in e.g. Toolbox's rpm subpackage
-testsbecause there's no script to package. This makes the package useless because the helper functions in system tests for pulling images rely on this mechanism being online.Describe the solution you'd like
Extract the image caching mechanism pro Zuul Ansible playbook into a script. Call the script in the CI instead.
Additional context
Greater usability/reliability of the tests means higher chance of having the tests used somewhere (e.g., containers/podman#10296).
The text was updated successfully, but these errors were encountered: