Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

toolbox 0.0.92 - unify toolbox create command with blog post #489

Closed
charafau opened this issue Jul 4, 2020 · 3 comments · Fixed by #493
Closed

toolbox 0.0.92 - unify toolbox create command with blog post #489

charafau opened this issue Jul 4, 2020 · 3 comments · Fixed by #493
Assignees
Labels
1. Bug Something isn't working
Milestone

Comments

@charafau
Copy link

charafau commented Jul 4, 2020

Hello! I saw HarryMichal's blog post about new version of podman rewritten in go - thank you for improving toolbox!
I compiled binary myself on Silverblue and one thing occurred to me.
In blog post ( http://harrymichal.undo.it/posts/2020/wheres-toolbox-0.0.9x-update/ ) I got an impression that toolbox commands got unified with podman and new (preferred) way to enter container is

toolbox enter <container-name>

but when I create new container message returned from toolbox displays old way of entering with --container parameter:

~ ➜ toolbox create my-container
Created container: my-container
Enter with: toolbox enter --container my-container

Not sure if that's intended or not so I decided to create this simple to fix issue, can create PR if someone decides that it's preferred way.

Thanks

@charafau charafau changed the title Podman 0.0.92 - unify toolbox create command with blog post toolbox 0.0.92 - unify toolbox create command with blog post Jul 4, 2020
@HarryMichal
Copy link
Member

Hi @charafau! Thank you for reading the blog post and trying out Toolbox.

The toolbox enter <container-name> command works it is just not shown in the "hint" after creating a container. I think this could be called an oversight.

@charafau
Copy link
Author

charafau commented Jul 7, 2020

thank you for fast answer - don't get me wrong, I know the command works, was just thinking which one should be "embraced" as output message with parameter or without :)

@HarryMichal HarryMichal added this to the Stable 1.0 milestone Jul 7, 2020
@HarryMichal HarryMichal self-assigned this Jul 7, 2020
@HarryMichal HarryMichal added the 1. Bug Something isn't working label Jul 7, 2020
@debarshiray
Copy link
Member

Thanks for catching this!

We kept advertising the old syntax in the user interface to retain compatibility with the POSIX shell implementation of Toolbox. Now that the Go implementation has proved to be robust and is being used widely, I agree that we should switch these things over.

debarshiray pushed a commit to HarryMichal/toolbox that referenced this issue Jul 22, 2020
Rewritten version of Toolbox supports newer syntax for entering a
container: `toolbox enter <name-of-container>`. This new workflow should
be shown in the hint after creating a container with `toolbox create`.

containers#489
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1. Bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants