Added support for CONTAINERS_STORAGE_CONF override #890
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Code looks good, but the tests don't like it. |
nalind
reviewed
May 10, 2021
vrothberg
reviewed
May 11, 2021
|
Can you squash the 5 commits into 1? |
|
LGTM |
rhatdan
reviewed
May 14, 2021
|
Could you also squash your commits? |
|
@molar Are you still working on this, or would you prefer I take it over? |
Signed-off-by: Morten Larsen <[email protected]>
giuseppe
approved these changes
Jun 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following the discussion from here
The
DefaultStoreOptionsnow checks if the environment variableCONTAINERS_STORAGE_CONFis set and uses that pathfor the configuration file. This is in line with how podman does it.
Please let me know your thoughts