Log expected rootless overlay mount failures as debug level #885
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Most linux kernels do not support overlay mounts in rootless mode, we should not be reporting this as an error, but drop it to debug level. Fixes: containers/podman#10153 Signed-off-by: Daniel J Walsh <[email protected]>
|
LGTM |
saschagrunert
approved these changes
Apr 28, 2021
vrothberg
reviewed
Apr 29, 2021
| @@ -620,7 +620,7 @@ func supportsOverlay(home string, homeMagic graphdriver.FsMagic, rootUID, rootGI | |||
| if len(flags) < unix.Getpagesize() { | |||
| err := unix.Mount("overlay", mergedDir, "overlay", 0, flags) | |||
| if err == nil { | |||
| logrus.Errorf("overlay test mount with multiple lowers failed, but succeeded with a single lower") | |||
| logrus.StandardLogger().Logf(logLevel, "overlay test mount with multiple lowers failed, but succeeded with a single lower") | |||
There was a problem hiding this comment.
I am a bit confused. Why not use .Debugf?
There was a problem hiding this comment.
logLevel is set to logrus.ErrorLevel for root and logrus.DebugLevel for rootless, so it is still an error when running as root
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most linux kernels do not support overlay mounts in rootless mode,
we should not be reporting this as an error, but drop it to debug
level.
Fixes: containers/podman#10153
Signed-off-by: Daniel J Walsh [email protected]