ReloadConfigurationFile should Reset storage options #867
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rhatdan
force-pushed
the
reload
branch
2 times, most recently
from
1007bdd to
0838108
Compare
rhatdan
changed the title
rhatdan
force-pushed
the
reload
branch
2 times, most recently
from
b9ecc81 to
d21a962
Compare
|
Basically I am trying to not use /var/lib/shared as an addiitonal store. CONTAINERS_STORAGE_CONF=/etc/containers/storage.conf.shared ./bin/podman --root /var/lib/shared pull alpine |
|
@containers/podman-maintainers PTAL |
|
How much of |
nalind
reviewed
Apr 1, 2021
|
I don't believe we want to retain anything, so just resetting storeOptions to init value. |
rhatdan
force-pushed
the
reload
branch
2 times, most recently
from
121ca21 to
82c4a9c
Compare
giuseppe
reviewed
Apr 6, 2021
types/options.go
Outdated
| @@ -278,6 +278,9 @@ func ReloadConfigurationFile(configFile string, storeOptions *StoreOptions) { | |||
| fmt.Printf("Failed to parse %s %v\n", configFile, err.Error()) | |||
| return | |||
| } | |||
|
|
|||
| // Clear storeOptions of previos settings | |||
| storeOptions = StoreOptions{} | |||
There was a problem hiding this comment.
should this be storeOptions = &StoreOptions{} ?
Currently in Podman if we reset the CONTAINERS_STORAGE_CONF path, we get the graph driver options from the original config file as well as the options from the override path. This PR resets the storageconf to the initial state when called multiple times. Also if user sets STORAGE_OPTS="" then we should use it to override all other storage options. Signed-off-by: Daniel J Walsh <[email protected]>
|
I want to get this in so we can cut a release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently in Podman if we reset the CONTAINERS_STORAGE_CONF path, we get
the graph driver options from the original config file as well as the
options from the override path. This PR resets the storageconf to the
initial state when called multiple times.
Signed-off-by: Daniel J Walsh [email protected]