overlay: allow to reset mount_program #847
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
if the mount_program is set to the empty string then clear its value and not use a mount program instead of failing. Signed-off-by: Giuseppe Scrivano <[email protected]>
saschagrunert
approved these changes
Mar 8, 2021
drivers/overlay/overlay.go
Outdated
| if val != "" { | ||
| _, err := os.Stat(val) | ||
| if err != nil { | ||
| return nil, fmt.Errorf("overlay: can't stat program %s: %v", val, err) |
There was a problem hiding this comment.
non-blocking nit since we're here
Suggested change
| return nil, fmt.Errorf("overlay: can't stat program %s: %v", val, err) | |
| return nil, errors.Wrapf(err, "overlay: can't stat program %s", val) |
There was a problem hiding this comment.
thanks! I've added a new patch with:
return nil, errors.Wrapf(err, "overlay: can't stat program %q", val)
Signed-off-by: Giuseppe Scrivano <[email protected]>
saschagrunert
approved these changes
Mar 8, 2021
|
LGTM |
|
tests are green now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
if the mount_program is set to the empty string then clear its value
and not use a mount program instead of failing.
Signed-off-by: Giuseppe Scrivano [email protected]