We need to use global GraphDriverOptions for rootless environments #709
Conversation
|
Currently in rootless podman we are not using the global envionment. We need to pass at least ignore_chown_errors down for rootless podman. We need to make sure that non VFS options are ignored if overlay is default. This would fix containers/podman#7513 but I think it is risky, we want this in the long run, but for the podman-2.0.* release we should just handle the ignore_chown_errors. |
utils.go
Outdated
| @@ -210,7 +209,7 @@ func getRootlessStorageOpts(rootlessUID int) (StoreOptions, error) { | |||
| opts.RootlessStoragePath = opts.GraphRoot | |||
| if path, err := exec.LookPath("fuse-overlayfs"); err == nil { | |||
| opts.GraphDriverName = "overlay" | |||
| opts.GraphDriverOptions = []string{fmt.Sprintf("overlay.mount_program=%s", path)} | |||
| opts.GraphDriverOptions = append(opts.GraphDriverOptions, fmt.Sprintf("overlay.mount_program=%s", path)) | |||
There was a problem hiding this comment.
Does this break when the system opts.GraphDriverName is not "overlay"?
There was a problem hiding this comment.
I am not sure. I think this could cause a few issues, which is why I stated that we need to be careful, even if this is the correct thing to do. I guess if we do the else option, we should just clear these fields.
There was a problem hiding this comment.
Could we copy these options only when opts.GraphDriver is also set to overlay?
|
@giuseppe PTAL |
Signed-off-by: Daniel J Walsh <[email protected]>
|
I am closing, since I now believe we want to move some of these flags to containtainers/common. |
Signed-off-by: Daniel J Walsh [email protected]