Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix goroutine leak with close tatLogger in a defer clause #706

Merged
merged 1 commit into from
Aug 31, 2020
Merged

fix goroutine leak with close tatLogger in a defer clause #706

merged 1 commit into from
Aug 31, 2020

Conversation

zvier
Copy link
Contributor

@zvier zvier commented Aug 31, 2020

Relate to #705

Signed-off-by: Jeff Zvier [email protected]

rhatdan
rhatdan approved these changes Aug 31, 2020
View reviewed changes
Copy link
Member

@rhatdan rhatdan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rhatdan
Copy link
Member

rhatdan commented Aug 31, 2020

@nalind @saschagrunert @giuseppe @vrothberg PTAL

@rhatdan
Copy link
Member

rhatdan commented Aug 31, 2020

Thanks @zvier

saschagrunert
saschagrunert approved these changes Aug 31, 2020
View reviewed changes
Copy link
Member

@saschagrunert saschagrunert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

giuseppe
giuseppe approved these changes Aug 31, 2020
View reviewed changes
Copy link
Member

@giuseppe giuseppe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@giuseppe giuseppe merged commit 250e2aa into containers:master Aug 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rhatdan rhatdan rhatdan approved these changes

@saschagrunert saschagrunert saschagrunert approved these changes

@giuseppe giuseppe giuseppe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@zvier @rhatdan @giuseppe @saschagrunert