counter: check for external umounts #698
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
if a previously mounted container was unmounted externally (e.g. through conmon cleanup for Podman containers), the ref counter will lose track of it and report it as still mounted. Closes: containers#697 Signed-off-by: Giuseppe Scrivano <[email protected]>
Closed
I don't like it too :-) but cannot think of a better way beside changing how podman/conmon cleanup work |
|
LGTM |
|
This fixes a critical bug we found in the Podman REST API tests. Can we prioritize getting this in? |
|
This isn't going to fix everything, but it's a step in the right direction. LGTM. |
rhatdan
added a commit
that referenced
this pull request
Aug 25, 2020
Cherry-pick #698 into v1.20-stable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
if a previously mounted container was unmounted
externally (e.g. through conmon cleanup for Podman containers), the
ref counter will lose track of it and report it as still mounted.
Closes: #697
Signed-off-by: Giuseppe Scrivano [email protected]