Allow users to override imagestores #689
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We have a request from a user who wants to use imagestores and to be able to update them from podman. Currently if I setup /var/lib/shared as an additional store and I attempt update the share with a command like: Error: lock "/var/lib/shared/overlay-images/images.lock" is not a read-only lock I can not because Podman is still using the additonal store. User expected something like: Error: overlay: Unknown option additionalimagestore To work. I looked further and figured overlay.imagestore would work, but it still failed. This PR allows users to specify additionalimagestores on the command line, and to use more likely options to make it work. I also cleanup some of the option parsing in overlay.go to handle overlay, overlay2, and "." prefixes. I checked and none of the other drivers use additionalimagestores options. Signed-off-by: Daniel J Walsh <[email protected]>
|
Partially fixes: containers/podman#7309 |
|
PR needs rebase |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have a request from a user who wants to use imagestores and
to be able to update them from podman.
Currently if I setup /var/lib/shared as an additional store
and I attempt update the share with a command like:
Error: lock "/var/lib/shared/overlay-images/images.lock" is not a read-only lock
I can not because Podman is still using the additonal store.
User expected something like:
Error: overlay: Unknown option additionalimagestore
To work.
I looked further and figured overlay.imagestore would work, but it still failed.
This PR allows users to specify additionalimagestores on the command line, and to use
more likely options to make it work.
I also cleanup some of the option parsing in overlay.go to handle overlay, overlay2, and "."
prefixes.
I checked and none of the other drivers use additionalimagestores options.
Signed-off-by: Daniel J Walsh [email protected]