reexec: drop Pdeathsig #530
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
it can lead to a race condition where the process is killed even if the parent process is still running. It can happen as the parent in the prctl(PR_SET_PDEATHSIG) case is considered the *thread* that created the process. In the case of the Go runtime the thread could be freed by the runtime at any time causing the re-execed process to receive the SIGTERM. Signed-off-by: Giuseppe Scrivano <[email protected]>
giuseppe
requested review from
nalind and
rhatdan
and removed request for
nalind
|
@giuseppe Do we loose any functionality from removing Pdeathsig? |
|
Nice catch! LGTM. |
|
LGTM |
rhatdan
approved these changes
Feb 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
it can lead to a race condition where the process is killed even if
the parent process is still running.
It can happen as the parent in the prctl(PR_SET_PDEATHSIG) case is
considered the thread that created the process. In the case of the
Go runtime the thread could be freed by the runtime at any time
causing the re-execed process to receive the SIGTERM.
Signed-off-by: Giuseppe Scrivano [email protected]