Fix a lock inversion #213
Merged
Fix a lock inversion #213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In CreateContainer(), don't use ROLayerStores() to get a list of the read-only layer stores after we've acquired the lock on the writeable layer store. ROLayerStores() acquires the graph lock, which we should never try to acquire while we're holding the layer store lock. Signed-off-by: Nalin Dahyabhai <[email protected]>
|
@mheon PTAL |
|
Change LGTM, though I don't have a consistent reproducer for the lock issue in question in my environment. Thanks for the quick work @nalind |
|
This attempts to fix containers/podman#1146. |
|
LGTM |
|
LGTM |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In CreateContainer(), don't use ROLayerStores() to get a list of the read-only layer stores after we've acquired the lock on the writeable layer store. ROLayerStores() acquires the graph lock, which we should never try to acquire while we're holding the layer store lock.