Add lock sanity checks to Save() methods #210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I have experienced "layer not known" corruption triggered by concurrent buildah/skopeo processes, and hopefully lock sanity checks will help to prevent this kind of problem. Signed-off-by: Zac Medico <[email protected]>
|
LGTM for finding bugs -- we shouldn't be saving when we don't have the lock. |
|
LGTM |
|
FWIW this broke cross-compilation to Windows. |
zmedico
added a commit
to zmedico/storage
that referenced
this pull request
Aug 28, 2018
The Locked() method must be implemented so that Save() will work on windows. Fixes: c7ba574 ("Add lock sanity checks to Save() methods") See: containers#210 (comment) Reported-by: Miloslav Trmač <[email protected]> Signed-off-by: Zac Medico <[email protected]>
zmedico
added a commit
to zmedico/storage
that referenced
this pull request
Aug 28, 2018
The Locked() method must be implemented so that Save() will work on windows. Fixes: c7ba574 ("Add lock sanity checks to Save() methods") See: containers#210 (comment) Reported-by: Miloslav Trmač <[email protected]> Signed-off-by: Zac Medico <[email protected]>
zmedico
added a commit
to zmedico/storage
that referenced
this pull request
Aug 28, 2018
The Locked() method must be implemented so that Save() will work on windows. Fixes: c7ba574 ("Add lock sanity checks to Save() methods") See: containers#210 (comment) Reported-by: Miloslav Trmač <[email protected]> Signed-off-by: Zac Medico <[email protected]>
|
I can confirm that c7ba574 has solved my concurrent buildah/skopeo "layer not known" corruption issue. There must be one or more |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have experienced "layer not known" corruption triggered by concurrent
buildah/skopeo processes, and hopefully lock sanity checks will help to
prevent this kind of problem.
Signed-off-by: Zac Medico [email protected]