log errors from ApplyUncompressedLayer

[TomasTomecek]

without

Writing manifest to image destination
Storing signatures
DEBU[0004] Start untar layer
Failed
ERRO[0004] error pulling image "docker.io/library/busybox": unable to pull docker.io/library/busybox: unable to find image in the registries defined in "/etc/containers/registries.conf"

with

Writing manifest to image destination
Storing signatures
DEBU[0005] Start untar layer
ERRO[0005] Error while applying layer: ApplyLayer exit status 1 stdout:  stderr: lchown /home: invalid argument
Failed
ERRO[0005] error pulling image "docker.io/library/busybox": unable to pull docker.io/library/busybox: unable to find image in the registries defined in "/etc/containers/registries.conf"

Related: containers/podman#1087

[rhatdan]

LGTM, although I would still like to make the higher level tools like buildah and podman check this if running as non root and using the mappings.
@nalind PTAL

[TomasTomecek]

+1, this is just a quick and dirty solution

Would be so nice to have a paragraph about this in a man page and point people to it via the error message.

[giuseppe]

Patch here: containers/podman#1097

[TomasTomecek]

Giuseppe, nicely done! I'm personally still in favor of merging this PR since the present code eats the error message and makes debugging things harder (strace needed to see the error message).

[giuseppe]

yes I agree, this patch is still nice to have. There might other cases when the error happens and there is no clear output to the user

[giuseppe]

LGTM