pkg/system: reduce retry timeout for EnsureRemoveAll #1723
Conversation
Signed-off-by: Giuseppe Scrivano <[email protected]>
reduce the waiting time for attempting again the removal to 10ms instead of the current 100ms. Currently, if we hit the timeout, we add an artificial 100ms delay to the container cleanup, while with this we will react faster when the removal is possible. Signed-off-by: Giuseppe Scrivano <[email protected]>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: giuseppe The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
LGTM |
|
The change looks OK to me. I'm just wondering if, given we're checking more quickly now, should we reduce the retry count to keep from hammering the system. I was thinking 500 instead of 1000. IDK, I'm fence-sitting and looking for other opinions. |
|
I think it is fine as it is so we have more time to recover from temporary failures. The operations involved are not too expensive so even every 10ms is still a relatively long time |
reduce the waiting time for attempting again the removal to 10ms instead of the current 100ms.
Currently, if we hit the timeout, we add an artificial 100ms delay to the container cleanup, while with this we will react faster when the removal is possible.
Signed-off-by: Giuseppe Scrivano [email protected]