Implement windows lockfile #1662
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikenorgate
force-pushed
the
windows-upstream
branch
4 times, most recently
from
841c869 to
5130df0
Compare
n1hility
requested changes
Jul 6, 2023
|
i only have one comment/suggestion here and its not a showstopper imo |
mikenorgate
force-pushed
the
windows-upstream
branch
from
5130df0 to
f4f3071
Compare
mtrmac
reviewed
Jul 7, 2023
mikenorgate
force-pushed
the
windows-upstream
branch
from
2ad2bca to
aa670bc
Compare
mtrmac
reviewed
Jul 7, 2023
|
@mtrmac I've made some updates based on your comments |
mtrmac
reviewed
Jul 10, 2023
| rwMutex: &sync.RWMutex{}, | ||
| stateMutex: &sync.Mutex{}, | ||
| lw: newLastWrite(), // For compatibility, the first call of .Modified() will always report a change. | ||
| lockType: lType, |
There was a problem hiding this comment.
Note to self:
- Isn’t this field only used if
locked? So it doesn’t actually need to be set here. - Actually
lockedandlockTypecould be combined.
Something to clean up later…
There was a problem hiding this comment.
- Actually
lockedandlockTypecould be combined.
On second thought, that might not be worthwhile, e.g. some of the lock functions would need to deal with the “unlocked” value.
|
@mikenorgate looks like you need to rebase this. |
mikenorgate
force-pushed
the
windows-upstream
branch
from
cfa60ea to
af8b6db
Compare
Signed-off-by: Mike Norgate <[email protected]>
mikenorgate
force-pushed
the
windows-upstream
branch
from
af8b6db to
1ad1a4e
Compare
mtrmac
approved these changes
Jul 12, 2023
|
Thanks again! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an implementation of
lockfilefor Windows, it includes a refactor of the Linux code to remove duplicationSigned-off-by: Mike Norgate [email protected]