store: ensure lockfile is updated before writes #1603
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mtrmac PTAL |
|
@nalind PTAL |
giuseppe
force-pushed
the
update-lock-before-write
branch
from
eb2a3eb to
89ddbb8
Compare
mtrmac
reviewed
May 18, 2023
The lockfile's write record is now updated prior to the actual write operation. This ensures that, in the event of an unexpected termination, other processes are correctly notified of an initiated write operation. Signed-off-by: Giuseppe Scrivano <[email protected]>
added the comment |
giuseppe
force-pushed
the
update-lock-before-write
branch
from
89ddbb8 to
ed76ab9
Compare
giuseppe
changed the title
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The lockfile's write record is now updated prior to the actual write operation. This ensures that, in the event of an unexpected termination, other processes are correctly notified of an initiated write operation.