store: prefer /etc/containers/storage.conf #1471
Conversation
giuseppe
force-pushed
the
default-override-for-rootless
branch
from
c4e9b9d to
8358880
Compare
when running in rootful mode, if it is present, prefer the override path /etc/containers/storage.conf instead of using the default storage.conf provided by the package under the /usr/share/containers/ directory. Signed-off-by: Giuseppe Scrivano <[email protected]>
giuseppe
force-pushed
the
default-override-for-rootless
branch
from
8358880 to
f64e1bd
Compare
|
@danishprakash PTAL |
There was a problem hiding this comment.
Doesn’t this need documentation?
Does this actually work? At least Podman callers use podman/pkg/rootless, which is a simple EUID check, not handling _CONTAINERS_ROOTLESS_UID. I would expect Podman to set !rootless inside a user namespace, then.
OTOH c/storage itself, in DefaultStoreOptionsAutoDetectUID, does check for _CONTAINERS_ROOTLESS_UID.
Is that intentional? If so, how does this work?
Please write these things down. What is the intended semantics of this rootless parameter? Then we can discuss whether it is being set correctly by callers; without that we have nothing to really discuss.
|
I agree the code that deals with configuration files is a complete mess and we handle it from so many different places that honestly I don't know how it all is supposed to fit. It took me a while to understand what is going with the issue I was looking at. What this PR changes is to honor |
I mean, depending on what this parameter means, this could either be a correct PR or a clear bug vs. the stated intent. I can’t see how propagating the current undefined state is sustainable, and I’m personally not interested. (There are enough other people on Cc:, and I won’t stand in the way of merging if they like it.) |
|
Lets merge and then work on fixing the documentation. I think the documentation does state that /etc/containers/storage.conf overrides /usr/share/containers/containers.conf. |
|
Is possible to backport this for 4.4.0 ? /usr/share/containers/ filesystem path is not writable in FCOS and AFAIK theres no other way, how to override storage.conf for API. |
|
Yes podman 4.4 will get the latest update containers/storage. |
when running in rootful mode, if it is present, prefer the override path /etc/containers/storage.conf instead of using the default storage.conf provided by the package under the /usr/share/containers/ directory.
Signed-off-by: Giuseppe Scrivano [email protected]