fix inconsitent go build tags #1417
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Lint is broken. |
Luap99
force-pushed
the
build-tags
branch
2 times, most recently
from
d428827 to
18ee330
Compare
Run `go fmt ./...` which automatically adds the new build tag syntax. This change is backwards compatible. Signed-off-by: Paul Holzinger <[email protected]>
Make sure all PRs are formated with `go fmt` correctly. I added it to the existing lint job as this seems to make the most sense to me. Signed-off-by: Paul Holzinger <[email protected]>
It is impossible to have this passing because it did not run in CI and invalid commit were merged since the fixed commit. The correct way should be to always use the merge base commit instead, at least this will only check commit that are actually part of the PR not all which is wasteful. Also removed unused $PATH overwrite and $GITVALIDATE_FLAGS var. Signed-off-by: Paul Holzinger <[email protected]>
|
This should good now, the one failure is caused by a CI issue. I do not have permission to restart it here. |
|
looks like it needs a rebase |
|
@rhatdan i think would be nice to get this vendored into podman, buildah, skopeo soon as possible. |
|
@lsm5 did you checked if it fixes your issue? |
|
Didn't check prior. Anyway, trying to vendor it now on f37 with golang v1.19.2 and I'm seeing unrelated vendoring issues I'll spin up a c9s vm in a bit and look further |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Run
go fmt ./...which automatically adds the new build tag syntax.This change is backwards compatible.
CI: run make local-validate
Make sure all PRs are formated with
go fmtcorrectly.I added it to the existing lint job as this seems to make the most
sense to me.