Code

Another bunch of warning cleanups#1364

Code

Merged

rhatdan merged 18 commits intocontainers:maincontainers/storage:mainfrom mtrmac:warningsmtrmac/storage:warningsCopy head branch name to clipboardOct 17, 2022

+1,024-967

Commits

Commits on Oct 14, 2022

• Use bytes.Equal instead of bytes.Compare

  Show description for 94f6ec8
  mtrmac

  committed
  94f6ec8

  Copy full SHA for 94f6ec8

• Exclude internal graphtest functions on platforms that don't call them

  Show description for 2637011
  mtrmac

  committed
  2637011

  Copy full SHA for 2637011

• Remove unused stubs

  Show description for 381c1f6
  mtrmac

  committed
  381c1f6

  Copy full SHA for 381c1f6

• Move code only called on Linux into a Linux-specific file

  Show description for a4870b9
  mtrmac

  committed
  a4870b9

  Copy full SHA for a4870b9

• Don't compile an unused stub on some Unix platforms

  Show description for ace738a
  mtrmac

  committed
  ace738a

  Copy full SHA for ace738a

• Move code unused on some architectures

  Show description for 767e0cd
  mtrmac

  committed
  767e0cd

  Copy full SHA for 767e0cd

• Misc individual warning fixes

  Show description for 5e410ef
  mtrmac

  committed
  5e410ef

  Copy full SHA for 5e410ef

• Rename ReadByte to readByte

  Show description for 7f0dae6
  mtrmac

  committed
  7f0dae6

  Copy full SHA for 7f0dae6

• Work around a paralleltest crash

  Show description for c497e66
  mtrmac

  committed
  c497e66

  Copy full SHA for c497e66

• Abort the writer in TarWithOptions on error

  Show description for 04a2f46
  mtrmac

  committed
  04a2f46

  Copy full SHA for 04a2f46

• Check for errors when creating empty files

  Show description for 7de868a
  mtrmac

  committed
  7de868a

  Copy full SHA for 7de868a

• Consolidate error reporting in cmd/containers-storage

  Show description for ace9c41
  mtrmac

  committed
  ace9c41

  Copy full SHA for ace9c41

• Add more error handling to cmd/containers-storage

  Show description for d60159b
  mtrmac

  committed
  d60159b

  Copy full SHA for d60159b

• Add missing error checks in tests

  Show description for 2d90000
  mtrmac

  committed
  2d90000

  Copy full SHA for 2d90000

• Only pass an io.Reader to invokeUnpack

  Show description for f3316c5
  mtrmac

  committed
  f3316c5

  Copy full SHA for f3316c5

• Use //nolint

  Show description for fe82b4d
  mtrmac

  committed
  fe82b4d

  Copy full SHA for fe82b4d

• Fix races in lockfile_test.go

  Show description for eeadee4
  mtrmac

  committed
  eeadee4

  Copy full SHA for eeadee4

• Merge branch 'main' into warnings

  rhatdan

  authored
  d02a89a

  Copy full SHA for d02a89a