Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Explain why a substring match is sufficient when reading uid_map #1330

Merged
merged 1 commit into from
Sep 10, 2022
Merged

Explain why a substring match is sufficient when reading uid_map #1330

merged 1 commit into from
Sep 10, 2022
+3 −1

Conversation

mtrmac
Copy link
Collaborator

@mtrmac mtrmac commented Sep 9, 2022

@mtrmac mtrmac mentioned this pull request Sep 9, 2022
Merged
@rhatdan
Copy link
Member

rhatdan commented Sep 9, 2022

LGTM

@rhatdan
Copy link
Member

rhatdan commented Sep 9, 2022

@nalind @vrothberg @giuseppe @TomSweeneyRedHat @umohnani8 @ashley-cui PTAL

TomSweeneyRedHat
TomSweeneyRedHat reviewed Sep 9, 2022
View reviewed changes
Copy link
Member

@TomSweeneyRedHat TomSweeneyRedHat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rhatdan rhatdan merged commit 01ea7a5 into containers:main Sep 10, 2022
@mtrmac mtrmac deleted the substring-comment branch September 10, 2022 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TomSweeneyRedHat TomSweeneyRedHat TomSweeneyRedHat left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mtrmac @rhatdan @TomSweeneyRedHat