chunked: drop host dedup feature #1256
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
giuseppe
force-pushed
the
chunked-drop-host-dedup
branch
from
a027994 to
8ace82d
Compare
|
You need to fix man pages. |
rhatdan
approved these changes
Jun 7, 2022
drop host deduplication by just looking at the file path. It could be useful in very specific use cases, but it is too expensive for generic images. If the need arises, we first need to create an index of the files that we can deduplicate so there is no need to calculate the checksum on the fly. Signed-off-by: Giuseppe Scrivano <[email protected]>
giuseppe
force-pushed
the
chunked-drop-host-dedup
branch
from
8ace82d to
268af00
Compare
fixed |
|
LGTM |
1 similar comment
|
LGTM |
|
LGTM for the record. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
drop host deduplication by just looking at the file path. It could be
useful in very specific use cases, but it is too expensive for generic
images. If the need arises, we first need to create an index of the
files that we can deduplicate so there is no need to calculate the
checksum on the fly.
Signed-off-by: Giuseppe Scrivano [email protected]