Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chunked: recalculate correctly the chunks to request #1236

Merged

Conversation

giuseppe
Copy link
Member

after the missing parts are merged, it is necessary to recalculate the chunks to ask to the server.

Signed-off-by: Giuseppe Scrivano [email protected]

@rhatdan
Copy link
Member

rhatdan commented May 11, 2022

LGTM
@nalind @vrothberg @saschagrunert @flouthoc PTAL

Copy link
Member

@saschagrunert saschagrunert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a single nit, otherwise LGTM

pkg/chunked/storage_linux.go Outdated Show resolved Hide resolved
@giuseppe giuseppe force-pushed the correctly-recreate-request-partial-pulls branch from 4849ac7 to ce4e541 Compare May 11, 2022 15:20
giuseppe added 2 commits May 11, 2022 17:21
after the missing parts are merged, it is necessary to recalculate the
chunks to ask to the server.

Signed-off-by: Giuseppe Scrivano <[email protected]>
@giuseppe giuseppe force-pushed the correctly-recreate-request-partial-pulls branch from ce4e541 to 75fd4d6 Compare May 11, 2022 15:21
Copy link
Collaborator

@flouthoc flouthoc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@flouthoc flouthoc merged commit 1ec5cc8 into containers:main May 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants