FreeBSD fixes for pkg/mount #1219
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
|
@containers/podman-maintainers PTAL |
vrothberg
reviewed
Apr 27, 2022
|
@dfr Could you rebase please although its not needed but github UI blocks merge button and only option is force merge. |
|
Rebased |
Also, we don't need to truncate the path name for zfs mount points. FreeBSD versions prior to 12.0 had a limitation of 88 characters for mount points but this has been increased to 1024. Signed-off-by: Doug Rabson <[email protected]>
Signed-off-by: Doug Rabson <[email protected]>
|
Ignoring the flakes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This uses MNT_FORCE as an approximation of Linux MNT_DETACH and passes through key/value options such as devfs' ruleset=N option to the kernel. Also, I removed the code which truncates the zfs mount point to work around a path name limit in obsolete versions of FreeBSD which was fixed in FreeBSD 12.