-
Notifications
You must be signed in to change notification settings - Fork 247
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch most calls to filepath.Walk to filepath.WalkDir #1176
Conversation
ad0d0f2
to
5c036e5
Compare
Newer golang is F36 only and in containers/podman#13376 |
The job description for https://cirrus-ci.com/task/4664820296318976?logs=setup#L176 says it's Fedora 34, but for whatever reason it's Fedora 33. The standard library introduced the |
a1f11ee
to
40be7e6
Compare
@cevich could you update the images for storage. Podman's images do not want. But I need newer versions of golang on f34. |
Yep. |
Let's see what #1182 do. |
All kinds of test unhappiness @rhatdan |
0e6a4b3
to
43c6eef
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Yup I am at a loss to why this works on Podman but not in storage. |
5c4dc4c
to
9327f72
Compare
Changes LGTM |
The |
IIUC, it's totally fine to just bump that up in the YAML, shouldn't affect anything other than that one lint task. |
3b383f2
to
58d6217
Compare
It is faster then Walk, when you don't need to stat every file and directory. Signed-off-by: Daniel J Walsh <[email protected]>
It is faster then Walk, when you don't need to stat every
file and directory.
Signed-off-by: Daniel J Walsh [email protected]