ExecRunnable: prevent logging on stderr when its not expected #1162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flouthoc
force-pushed
the
clean-error-unshare
branch
from
aaa046e to
07400b8
Compare
ExecRunnable is invoked by buildah and error from c/storage is logged to stdout. This creates a drift between the between the behavior which is generated by rootless and rootful buildah. This corrects the behavior for rootless buildah so it has parity with buildah invoked for root user. This helps in containers/buildah#3804 Signed-off-by: Aditya R <[email protected]>
flouthoc
force-pushed
the
clean-error-unshare
branch
from
07400b8 to
d995ec4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ExecRunnable is invoked by buildah and error from c/storage is logged to
stdout. This creates a drift between the between the behavior which is
generated by rootless and rootful buildah.
This corrects the behavior for rootless buildah so it has parity with
buildah invoked for root user.
This helps in issue being discussed here: containers/buildah#3804 (comment)