RFC: Warn if we are deleting an incomplete layer #1145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I am fine logging at this level. If this happens commonly we need to know about it. LGTM |
mtrmac
force-pushed
the
delete-incomplete-warn
branch
from
d6b1a49 to
ece0e83
Compare
... to help diagnosing later possible broken references to this layer; compare containers#1136 . Signed-off-by: Miloslav Trmač <[email protected]>
mtrmac
force-pushed
the
delete-incomplete-warn
branch
from
ece0e83 to
5654974
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... to help diagnosing later possible broken references to this layer; compare #1136 for situations where that might be relevant.
Note: This will add user-visible warnings even in situations where we are handling incomplete layers correctly. Maybe we should just fix #1136 and the like, and then only log this at a debug level.